Issue-949: Fixing inconsistencies in output schema #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stan-sb
commented
Jun 19, 2020
stan-sb
commented
- Changing "oneOf" to "anyOf", because basic, detailed and verbose have the same definition, oneOf would fail validation.
- Adding "error" keyword and making either "error" or "errors" required in case "valid" is false.
1. Changing "oneOf" to "anyOf", because basic, detailed and verbose have the same definition, oneOf would fail validation. 2. Adding "error" keyword and making either "error" or "errors" required in case "valid" is false.
|
#940 also addresses oneOf -> anyOf. |
|
@karenetheridge has @stan-sb addressed your concerns with his last comment? I'd like to get a review from either you or @gregsdennis and get this merged if it is correct. |
|
@gregsdennis @karenetheridge any update on this? I'd like to get it merged or rejected, whichever is appropriate. We need to wrap up this draft and this has been open for 3 months now. |
|
I have no strong feelings. I had used |
gregsdennis
approved these changes
Sep 26, 2020
gregsdennis
requested changes
Sep 26, 2020
output/schema.json
Outdated
| @@ -41,7 +44,14 @@ | |||
| } | |||
| }, | |||
| "then": { | |||
| "required": [ "errors" ] | |||
| "oneOf": [ | |||
There was a problem hiding this comment.
anyOf here, too. Don't preclude having both.
handrews
reviewed
Oct 1, 2020
Make anyOf (instead of oneOf) consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.