Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation: Add "propertyNames" keyword #172

Merged
merged 1 commit into from
Dec 13, 2016

Conversation

awwright
Copy link
Member

Language for #70

@awwright awwright added this to the draft-next milestone Nov 30, 2016
@awwright awwright force-pushed the validation-propertyNames branch from 3280742 to f1a7b77 Compare November 30, 2016 14:16
Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add this to the hyper-schema meta-schema as well, plus we need to see how #171 plays out.

Aside from that this looks good to me as long as @epoberezkin approves since it was his issue.

Note the property name that the schema is testing will always be a string.
</t>
<t>
A missing keyword is the same as an empty schema, or a schema testing that the type is "string".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same objection to this language as in PR #171, so this should be adjusted based on the resolution of that PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can say "A missing keyword exhibits the same behavior as an empty schema" or something like that... The thing is it has to be informative, since it's noting something that's already true.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@handrews @awwright I am ok with the current language or with "defaults to empty schema" (which will be consistent with meta-schema).

@awwright awwright closed this Dec 11, 2016
@awwright awwright deleted the validation-propertyNames branch December 11, 2016 19:32
@awwright awwright restored the validation-propertyNames branch December 11, 2016 19:33
@awwright awwright reopened this Dec 11, 2016
@awwright awwright modified the milestones: Meta-schema draft-05, draft-next (draft-6) Dec 11, 2016
@awwright awwright force-pushed the validation-propertyNames branch from f1a7b77 to 40646a6 Compare December 11, 2016 19:50
@awwright
Copy link
Member Author

I just removed the paragraph, we can figure out what to do in #171 regarding "default" language

@epoberezkin
Copy link
Member

at least something useful from me, not just the stream of disruption ;)

@awwright awwright deleted the validation-propertyNames branch December 20, 2016 21:59
@awwright awwright restored the validation-propertyNames branch December 21, 2016 00:52
@awwright awwright deleted the validation-propertyNames branch December 21, 2016 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants