Rely on supported AllOf approach for creating nullable reference schemas
#1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iTestContext to allow for this
…nd-nullable-properties
Merge openapi branch into PR 1185: Support NRT and MSV in required and nullable
OpenApiTests/SchemaProperties test collection: * Allow for usage of OpenApiStartup directly * Remove unneeded adding of JsonConverter * Replace null checks with .ShouldHaveCount() calls * Adjust test names Misc: * Reverted .editorconfig changes and fixed ApiException constructor instead * Remove Debug statement
SchemaProperty Tests: * More rigorous test suite, see PR description IJsonApiClient: * Renamed registration method to a more functionally descriptive name. * Improved documentation to contain most relevant information on top instead of at the end, and removed ambiguigity in wording. JsonApiClient * Fix bug: disallow omitting members that are explicitly required by the OAS description * Renamed AttributeNamesContainer to AttributesObjectContext because it was more than just a container * Misc: better variable naming
…t more generally request behaviour
… with existing test suite - Use existing DbContext instead of temporary one
…a-property-tests Improved JsonApiClient and relationships into `openapi-required-and-nullable`
-> in sync with latest version of nullability/required table -> introduces ResourceFieldValidationMetadataProvider -> Fix test in legacy projects -> Reusable faker building block for OpenApiClient related concerns
… caching in object extension
maurei
changed the title
AllOf approach for creating nullable reference schemasAllOf approach for creating nullable reference schemas
Base automatically changed from
openapi-required-and-nullable-properties
to
openapi
October 9, 2023 19:15
|
Superseded by #1372. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the Swashbuckle built-in support for
AllOfto create nullable reference schema types, rather than the approach I had before usingoneOf, see domaindrivendev/Swashbuckle.AspNetCore#861.Apart from yielding a cleaner implementation, it will also be needed to properly support complex attributes as per #1051.
Todo: set base branch to
open-apionce #1185 is merged.