Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationship capabilities and bugfixes #1197

Merged
merged 8 commits into from
Oct 20, 2022
Merged

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Oct 1, 2022

Adds the equivalent of AttrCapabilities for relationships. See #1187 for design considerations.
This PR also fixes some small bugs.

Closes #1187.
Fixes #1196.
Fixes #1195.
Fixes #1198.
Fixes #1199.

QUALITY CHECKLIST

@bkoelman
Copy link
Member Author

bkoelman commented Oct 1, 2022

This PR has a dependency on #1192. If that one is merged earlier, this PR needs additional changes.

@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Merging #1197 (35ec18f) into master (ea3ab72) will increase coverage by 0.08%.
The diff coverage is 95.16%.

❗ Current head 35ec18f differs from pull request most recent head 4b725bd. Consider uploading reports for the commit 4b725bd to get more accurate results

@@            Coverage Diff             @@
##           master    #1197      +/-   ##
==========================================
+ Coverage   92.61%   92.69%   +0.08%     
==========================================
  Files         242      243       +1     
  Lines        7701     7803     +102     
==========================================
+ Hits         7132     7233     +101     
- Misses        569      570       +1     
Impacted Files Coverage Δ
...Annotations/Resources/Annotations/AttrAttribute.cs 90.00% <ø> (ø)
...ns/Resources/Annotations/ResourceFieldAttribute.cs 65.00% <ø> (ø)
...ourceGenerators/TypeWithAttributeSyntaxReceiver.cs 100.00% <ø> (ø)
src/JsonApiDotNetCore/Configuration/TypeLocator.cs 89.74% <ø> (ø)
...ation/JsonConverters/WriteOnlyDocumentConverter.cs 91.66% <ø> (ø)
...Converters/WriteOnlyRelationshipObjectConverter.cs 81.25% <ø> (ø)
...piDotNetCore/Configuration/ResourceGraphBuilder.cs 97.12% <85.71%> (-1.57%) ⬇️
...re/Resources/Annotations/CapabilitiesExtensions.cs 88.00% <88.00%> (ø)
...otations/Resources/Annotations/HasManyAttribute.cs 100.00% <100.00%> (ø)
...notations/Resources/Annotations/HasOneAttribute.cs 100.00% <100.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bkoelman bkoelman marked this pull request as ready for review October 1, 2022 20:36
@bkoelman bkoelman requested a review from maurei October 1, 2022 20:36
@bkoelman bkoelman force-pushed the relationship-capabilities branch from a6dc59b to 0ca0c12 Compare October 2, 2022 15:47
@bkoelman bkoelman force-pushed the relationship-capabilities branch from 0ca0c12 to f2c6029 Compare October 3, 2022 18:32
@maurei
Copy link
Member

maurei commented Oct 19, 2022

Reviewed extensively, work is very clean 👍

@bkoelman bkoelman requested a review from maurei October 19, 2022 17:18
@maurei maurei merged commit af46168 into master Oct 20, 2022
@maurei maurei deleted the relationship-capabilities branch October 20, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment