Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mutually exclusive class args allowed when running with flake8 #452

Closed
jshwi opened this issue Sep 21, 2024 · 0 comments · Fixed by #453
Closed

mutually exclusive class args allowed when running with flake8 #452

jshwi opened this issue Sep 21, 2024 · 0 comments · Fixed by #453
Assignees
@jshwi

Comments

@jshwi
Copy link
Owner

jshwi commented Sep 21, 2024

mutually exclusive class args are not allowed when running docsig on its own

flake8 . --sig-check-class --sig-check-class-constructor

Should result in something like "argument to check class constructor not allowed with argument to check class"

Environment:

  • 3.8
  • 0.61.0
@jshwi jshwi self-assigned this Sep 21, 2024
jshwi added a commit that referenced this issue Sep 21, 2024
@jshwi
fix: disallow both class args with flake8 (#452)
1c59add 
Signed-off-by: Stephen Whitlock <[email protected]>
@jshwi jshwi linked a pull request Sep 21, 2024 that will close this issue
452 mutually exclusive class args allowed when running with flake8 #453
Merged
jshwi added a commit that referenced this issue Sep 21, 2024
@jshwi
fix: disallow both class args with flake8 (#452)
d7a2b95 
Signed-off-by: Stephen Whitlock <[email protected]>
jshwi added a commit that referenced this issue Sep 21, 2024
@jshwi
fix: disallow both class args with flake8 (#452)
0238f27 
Signed-off-by: Stephen Whitlock <[email protected]>
jshwi added a commit that referenced this issue Sep 21, 2024
@jshwi
fix: disallow both class args with flake8 (#452)
62628de 
Signed-off-by: Stephen Whitlock <[email protected]>
jshwi added a commit that referenced this issue Sep 21, 2024
@jshwi
fix: disallow both class args with flake8 (#452)
32cbdf8 
Signed-off-by: Stephen Whitlock <[email protected]>
jshwi added a commit that referenced this issue Sep 21, 2024
@jshwi
fix: disallow both class args with flake8 (#452)
7338692 
Signed-off-by: Stephen Whitlock <[email protected]>
jshwi added a commit that referenced this issue Sep 21, 2024
@jshwi
fix: disallow both class args with flake8 (#452)
4f98c7d 
Signed-off-by: Stephen Whitlock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshwi jshwi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

452 mutually exclusive class args allowed when running with flake8 jshwi/docsig
1 participant
@jshwi