-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude cannot handle directory #392
Comments
Signed-off-by: Stephen Whitlock <[email protected]>
Signed-off-by: Stephen Whitlock <[email protected]>
Signed-off-by: Stephen Whitlock <[email protected]>
Signed-off-by: Stephen Whitlock <[email protected]>
Signed-off-by: Stephen Whitlock <[email protected]>
Hey @LisPrzemyslaw |
Signed-off-by: Stephen Whitlock <[email protected]>
Match pattern against full path instead of each part at a time Exclude rules now also handle windows paths Signed-off-by: Stephen Whitlock <[email protected]>
Match pattern against full path instead of each part at a time Exclude rules now also handle windows paths Signed-off-by: Stephen Whitlock <[email protected]>
Match pattern against full path instead of each part at a time Default exclude rules now also handle windows paths Signed-off-by: Stephen Whitlock <[email protected]>
Match pattern against full path instead of each part at a time Default exclude rules now also handle windows paths Signed-off-by: Stephen Whitlock <[email protected]>
Match pattern against full path instead of each part at a time Signed-off-by: Stephen Whitlock <[email protected]>
@LisPrzemyslaw , I'm pretty satisfied this is fixed now, I tried on mac and my windows vm |
I've tested it and it is working. @jshwi thanks a lot! Good job! 🚀 |
Awesome, no worries at all @LisPrzemyslaw ! Thanks for confirming 😄 |
The exclude files cannot hold the whole dictionary. The regex pattern checks only for the name of the file so in a case that you have 2 similar file names but in different folders then you have to exclude both.
Replace bug:
In my case I'm using poetry so the config file looks like this:
pyproject.toml
The design folder should be excluded. But it is not. This line makes nothing.
Expected:
The whole folder is not in checks.
Possible solution:
right now in _files.py::Paths::_populate there is a regex match
_re.match(i, root.name)
and to proper work it should be a_re.match(i, str(name))
This will allows to check whole folders instead of only one file. It is really important if you have the same names in different folders and only one should be excluded.Environment:
The text was updated successfully, but these errors were encountered: