Convert to AndroidX and fix package structure

jshvarts · May 19, 2019 · d309fed · d309fed
1 parent 40f15e6
commit d309fed
Show file tree

Hide file tree

Showing 16 changed files with 52 additions and 46 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -9,19 +9,19 @@ apply plugin: 'kotlin-android-extensions'
 project.ext {
     supportLibraryVersion = "28.0.0"
     daggerVersion = "2.22.1"
-    butterKnifeVersion = "8.5.1"
+    butterKnifeVersion = "10.1.0"
 }
 
 android {
     compileSdkVersion 28
     buildToolsVersion "28.0.3"
     defaultConfig {
-        applicationId "com.jshvarts.daggerandroidsampleapp"
+        applicationId "com.jshvarts.daggerandroidmvp"
         minSdkVersion 19
         targetSdkVersion 28
         versionCode 1
         versionName "1.0"
-        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
+        testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     buildTypes {
         release {
@@ -34,12 +34,16 @@ android {
         test.java.srcDirs += 'src/test/kotlin'
         androidTest.java.srcDirs += 'src/androidTest/kotlin'
     }
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_1_8
+        targetCompatibility JavaVersion.VERSION_1_8
+    }
 }
 
 dependencies {
     implementation fileTree(dir: 'libs', include: ['*.jar'])
-    implementation"org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
-    implementation "com.android.support:appcompat-v7:$project.supportLibraryVersion"
+    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
+    implementation "androidx.appcompat:appcompat:1.0.2"
 
     // Dagger Core
     implementation "com.google.dagger:dagger:$project.daggerVersion"

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -1,16 +1,16 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="com.jshvarts.daggerandroidsampleapp">
+    package="com.jshvarts.daggerandroidmvp">
 
     <application
-        android:name=".App"
+        android:name="com.jshvarts.daggerandroidmvp.App"
         android:allowBackup="true"
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
         android:roundIcon="@mipmap/ic_launcher_round"
         android:supportsRtl="true"
         android:theme="@style/AppTheme">
-        <activity android:name=".lobby.LobbyActivity">
+        <activity android:name="com.jshvarts.daggerandroidmvp.lobby.LobbyActivity">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />
 

diff --git a/...om/jshvarts/daggerandroidsampleapp/App.kt → ...tlin/com/jshvarts/daggerandroidmvp/App.kt b/...om/jshvarts/daggerandroidsampleapp/App.kt → ...tlin/com/jshvarts/daggerandroidmvp/App.kt
@@ -1,8 +1,8 @@
-package com.jshvarts.daggerandroidsampleapp
+package com.jshvarts.daggerandroidmvp
 
 import android.app.Activity
 import android.app.Application
-import com.jshvarts.daggerandroidsampleapp.di.DaggerAppComponent
+import com.jshvarts.daggerandroidmvp.di.DaggerAppComponent
 import dagger.android.AndroidInjector
 import dagger.android.HasActivityInjector
 import dagger.android.DispatchingAndroidInjector
@@ -22,4 +22,4 @@ class App : Application(), HasActivityInjector {
     }
 
     override fun activityInjector(): AndroidInjector<Activity> = activityInjector
-}
+}
diff --git a/...mpleapp/common/data/CommonHelloService.kt → ...roidmvp/common/data/CommonHelloService.kt b/...mpleapp/common/data/CommonHelloService.kt → ...roidmvp/common/data/CommonHelloService.kt
@@ -1,5 +1,5 @@
-package com.jshvarts.daggerandroidsampleapp.common.data
+package com.jshvarts.daggerandroidmvp.common.data
 
 class CommonHelloService {
     fun sayHello() = "Hello from CommonHelloService"
-}
+}
diff --git a/...erandroidsampleapp/di/ActivitiesModule.kt → ...s/daggerandroidmvp/di/ActivitiesModule.kt b/...erandroidsampleapp/di/ActivitiesModule.kt → ...s/daggerandroidmvp/di/ActivitiesModule.kt
@@ -1,9 +1,9 @@
-package com.jshvarts.daggerandroidsampleapp.di
+package com.jshvarts.daggerandroidmvp.di
 
-import com.jshvarts.daggerandroidsampleapp.lobby.LobbyActivity
-import com.jshvarts.daggerandroidsampleapp.lobby.LobbyActivityModule
-import com.jshvarts.daggerandroidsampleapp.lobby.LobbyFragment
-import com.jshvarts.daggerandroidsampleapp.lobby.LobbyFragmentModule
+import com.jshvarts.daggerandroidmvp.lobby.LobbyActivity
+import com.jshvarts.daggerandroidmvp.lobby.LobbyActivityModule
+import com.jshvarts.daggerandroidmvp.lobby.LobbyFragment
+import com.jshvarts.daggerandroidmvp.lobby.LobbyFragmentModule
 import dagger.Module
 import dagger.android.ContributesAndroidInjector
 
@@ -17,4 +17,4 @@ abstract class ActivitiesModule {
     // or access to lobby dependencies from fragment via:
     // @ContributesAndroidInjector(modules = {LobbyFragmentModule.class, LobbyActivityModule.class})
     abstract fun bindLobbyFragment(): LobbyFragment
-}
+}
diff --git a/...daggerandroidsampleapp/di/AppComponent.kt → ...varts/daggerandroidmvp/di/AppComponent.kt b/...daggerandroidsampleapp/di/AppComponent.kt → ...varts/daggerandroidmvp/di/AppComponent.kt
@@ -1,6 +1,6 @@
-package com.jshvarts.daggerandroidsampleapp.di
+package com.jshvarts.daggerandroidmvp.di
 
-import com.jshvarts.daggerandroidsampleapp.App
+import com.jshvarts.daggerandroidmvp.App
 import dagger.Component
 import dagger.android.AndroidInjectionModule
 import javax.inject.Singleton
@@ -13,4 +13,4 @@ import javax.inject.Singleton
 ))
 interface AppComponent {
     fun inject(app: App)
-}
+}
diff --git a/...ts/daggerandroidsampleapp/di/AppModule.kt → ...jshvarts/daggerandroidmvp/di/AppModule.kt b/...ts/daggerandroidsampleapp/di/AppModule.kt → ...jshvarts/daggerandroidmvp/di/AppModule.kt
@@ -1,7 +1,7 @@
-package com.jshvarts.daggerandroidsampleapp.di
+package com.jshvarts.daggerandroidmvp.di
 
 import android.app.Application
-import com.jshvarts.daggerandroidsampleapp.common.data.CommonHelloService
+import com.jshvarts.daggerandroidmvp.common.data.CommonHelloService
 import dagger.Module
 import dagger.Provides
 import javax.inject.Singleton
@@ -15,4 +15,4 @@ class AppModule {
     @Singleton
     @Provides
     fun providesCommonHelloService() = CommonHelloService()
-}
+}
diff --git a/...s/daggerandroidmvp/lobby/LobbyActivity.kt → ...s/daggerandroidmvp/lobby/LobbyActivity.kt b/...s/daggerandroidmvp/lobby/LobbyActivity.kt → ...s/daggerandroidmvp/lobby/LobbyActivity.kt
@@ -1,20 +1,19 @@
-package com.jshvarts.daggerandroidsampleapp.lobby
+package com.jshvarts.daggerandroidmvp.lobby
 
-import android.app.Fragment
-import android.support.v7.app.AppCompatActivity
+import androidx.appcompat.app.AppCompatActivity
 import android.os.Bundle
-import com.jshvarts.daggerandroidsampleapp.R
-import com.jshvarts.daggerandroidsampleapp.common.data.CommonHelloService
+import com.jshvarts.daggerandroidmvp.R
+import com.jshvarts.daggerandroidmvp.common.data.CommonHelloService
 import dagger.android.AndroidInjection
 import dagger.android.AndroidInjector
 import dagger.android.HasFragmentInjector
 import javax.inject.Inject
 import dagger.android.DispatchingAndroidInjector
 import android.widget.TextView
+import android.app.Fragment
 import butterknife.BindView
 import butterknife.ButterKnife
 
-
 class LobbyActivity : AppCompatActivity(), HasFragmentInjector {
 
     @Inject

diff --git a/...oidmvp/lobby/LobbyActivityHelloService.kt → ...oidmvp/lobby/LobbyActivityHelloService.kt b/...oidmvp/lobby/LobbyActivityHelloService.kt → ...oidmvp/lobby/LobbyActivityHelloService.kt
@@ -1,5 +1,5 @@
-package com.jshvarts.daggerandroidsampleapp.lobby
+package com.jshvarts.daggerandroidmvp.lobby
 
 class LobbyActivityHelloService {
     fun sayHello() = "Hello from LobbyActivityHelloService"
-}
+}
diff --git a/...erandroidmvp/lobby/LobbyActivityModule.kt → ...erandroidmvp/lobby/LobbyActivityModule.kt b/...erandroidmvp/lobby/LobbyActivityModule.kt → ...erandroidmvp/lobby/LobbyActivityModule.kt
@@ -1,4 +1,4 @@
-package com.jshvarts.daggerandroidsampleapp.lobby
+package com.jshvarts.daggerandroidmvp.lobby
 
 import dagger.Module
 import dagger.Provides
@@ -8,4 +8,4 @@ class LobbyActivityModule {
 
     @Provides
     fun provideLobbyActivityHelloService() = LobbyActivityHelloService()
-}
+}
diff --git a/...s/daggerandroidmvp/lobby/LobbyFragment.kt → ...s/daggerandroidmvp/lobby/LobbyFragment.kt b/...s/daggerandroidmvp/lobby/LobbyFragment.kt → ...s/daggerandroidmvp/lobby/LobbyFragment.kt
@@ -1,6 +1,5 @@
-package com.jshvarts.daggerandroidsampleapp.lobby
+package com.jshvarts.daggerandroidmvp.lobby
 
-import android.app.Fragment
 import android.content.Context
 import android.os.Bundle
 import android.view.LayoutInflater
@@ -9,9 +8,10 @@ import android.view.ViewGroup
 import dagger.android.AndroidInjection
 import javax.inject.Inject
 import android.widget.TextView
+import android.app.Fragment
 import butterknife.BindView
 import butterknife.ButterKnife
-import com.jshvarts.daggerandroidsampleapp.R
+import com.jshvarts.daggerandroidmvp.R
 import butterknife.Unbinder
 
 class LobbyFragment : Fragment() {
@@ -22,7 +22,7 @@ class LobbyFragment : Fragment() {
     @BindView(R.id.lobby_fragment_hello)
     lateinit var lobbyFragmentHelloTextView: TextView
 
-    lateinit var unbinder: Unbinder
+    private lateinit var unbinder: Unbinder
 
     override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
         val view = inflater.inflate(R.layout.lobby_fragment, container, false)
@@ -49,4 +49,4 @@ class LobbyFragment : Fragment() {
     private fun sayFragmentHello() {
         lobbyFragmentHelloTextView.text = lobbyFragmentHelloService.sayHello()
     }
-}
+}
diff --git a/...oidmvp/lobby/LobbyFragmentHelloService.kt → ...oidmvp/lobby/LobbyFragmentHelloService.kt b/...oidmvp/lobby/LobbyFragmentHelloService.kt → ...oidmvp/lobby/LobbyFragmentHelloService.kt
@@ -1,5 +1,5 @@
-package com.jshvarts.daggerandroidsampleapp.lobby
+package com.jshvarts.daggerandroidmvp.lobby
 
 class LobbyFragmentHelloService {
     fun sayHello() = "Hello from LobbyFragmentHelloService"
-}
+}
diff --git a/...erandroidmvp/lobby/LobbyFragmentModule.kt → ...erandroidmvp/lobby/LobbyFragmentModule.kt b/...erandroidmvp/lobby/LobbyFragmentModule.kt → ...erandroidmvp/lobby/LobbyFragmentModule.kt
@@ -1,4 +1,4 @@
-package com.jshvarts.daggerandroidsampleapp.lobby
+package com.jshvarts.daggerandroidmvp.lobby
 
 import dagger.Module
 import dagger.Provides
@@ -8,4 +8,4 @@ class LobbyFragmentModule {
 
     @Provides
     fun provideLobbyFragmentHelloService() = LobbyFragmentHelloService()
-}
+}
diff --git a/app/src/main/res/layout/lobby_activity.xml b/app/src/main/res/layout/lobby_activity.xml
@@ -4,7 +4,7 @@
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:orientation="vertical"
-    tools:context="com.jshvarts.daggerandroidsampleapp.lobby.LobbyActivity">
+    tools:context="com.jshvarts.daggerandroidmvp.lobby.LobbyActivity">
 
     <TextView
         android:id="@+id/common_hello"
@@ -22,7 +22,7 @@
 
     <fragment
         android:id="@+id/lobby_fragment"
-        android:name="com.jshvarts.daggerandroidsampleapp.lobby.LobbyFragment"
+        android:name="com.jshvarts.daggerandroidmvp.lobby.LobbyFragment"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_gravity="center_horizontal"

diff --git a/build.gradle b/build.gradle
@@ -5,6 +5,7 @@ buildscript {
     repositories {
         google()
         jcenter()
+        mavenCentral()
     }
     dependencies {
         classpath 'com.android.tools.build:gradle:3.4.0'

diff --git a/gradle.properties b/gradle.properties
@@ -9,6 +9,8 @@
 
 # Specifies the JVM arguments used for the daemon process.
 # The setting is particularly useful for tweaking memory settings.
+android.enableJetifier=true
+android.useAndroidX=true
 org.gradle.jvmargs=-Xmx1536m
 
 # When configured, Gradle will run in incubating parallel mode.