Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci pipeline with newer Node.js versions and use nyc for coverage #17

Merged
merged 1 commit into from
Jun 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 64 additions & 25 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,56 +29,62 @@ jobs:
- Node.js 14.x
- Node.js 15.x
- Node.js 16.x
- Node.js 17.x
- Node.js 18.x
- Node.js 19.x
- Node.js 20.x
- Node.js 21.x
- Node.js 22.x

include:
- name: Node.js 0.8
node-version: "0.8"
npm-i: [email protected]
npm-rm: istanbul
npm-rm: nyc

- name: Node.js 0.10
node-version: "0.10"
npm-i: [email protected]
npm-i: [email protected] [email protected]

- name: Node.js 0.12
node-version: "0.12"
npm-i: [email protected]
npm-i: [email protected] [email protected]

- name: io.js 1.x
node-version: "1.8"
npm-i: [email protected]
npm-i: [email protected] [email protected]

- name: io.js 2.x
node-version: "2.5"
npm-i: [email protected]
npm-i: [email protected] [email protected]

- name: io.js 3.x
node-version: "3.3"
npm-i: [email protected]
npm-i: [email protected] [email protected]

- name: Node.js 4.x
node-version: "4.9"
npm-i: [email protected]
npm-i: [email protected] [email protected]

- name: Node.js 5.x
node-version: "5.12"
npm-i: [email protected]
npm-i: [email protected] [email protected]

- name: Node.js 6.x
node-version: "6.17"
npm-i: [email protected].3
npm-i: [email protected].2 [email protected]

- name: Node.js 7.x
node-version: "7.10"
npm-i: [email protected].3
npm-i: [email protected].2 [email protected]

- name: Node.js 8.x
node-version: "8.16"
npm-i: mocha@7.2.0
node-version: "8.17"
npm-i: mocha@7.1.2 [email protected]

- name: Node.js 9.x
node-version: "9.11"
npm-i: mocha@7.2.0
npm-i: mocha@7.1.2 [email protected]

- name: Node.js 10.x
node-version: "10.24"
Expand All @@ -90,33 +96,66 @@ jobs:

- name: Node.js 12.x
node-version: "12.22"
npm-i: [email protected]

- name: Node.js 13.x
node-version: "13.14"
npm-i: [email protected]

- name: Node.js 14.x
node-version: "14.17"
node-version: "14.21"

- name: Node.js 15.x
node-version: "15.14"

- name: Node.js 16.x
node-version: "16.7"
node-version: "16.20"

- name: Node.js 17.x
node-version: "17.9"

- name: Node.js 18.x
node-version: "18.20"

- name: Node.js 19.x
node-version: "19.9"

- name: Node.js 20.x
node-version: "20.13"

- name: Node.js 21.x
node-version: "21.7"

- name: Node.js 22.x
node-version: "22.1"

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Install Node.js ${{ matrix.node-version }}
shell: bash -eo pipefail -l {0}
run: |
nvm install --default ${{ matrix.node-version }}
if [[ "${{ matrix.node-version }}" == 0.* ]]; then
if [[ "${{ matrix.node-version }}" == 0.* && "$(cut -d. -f2 <<< "${{ matrix.node-version }}")" -lt 10 ]]; then
nvm install --alias=npm 0.10
nvm use ${{ matrix.node-version }}
if [[ "$(npm -v)" == 1.1.* ]]; then
nvm exec npm npm install -g [email protected]
ln -fs "$(which npm)" "$(dirname "$(nvm which npm)")/npm"
else
sed -i '1s;^.*$;'"$(printf '#!%q' "$(nvm which npm)")"';' "$(readlink -f "$(which npm)")"
fi
npm config set strict-ssl false
fi
dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH"

- name: Configure npm
run: npm config set shrinkwrap false
run: |
if [[ "$(npm config get package-lock)" == "true" ]]; then
npm config set package-lock false
else
npm config set shrinkwrap false
fi

- name: Remove npm module(s) ${{ matrix.npm-rm }}
run: npm rm --silent --save-dev ${{ matrix.npm-rm }}
Expand All @@ -130,8 +169,8 @@ jobs:
shell: bash
run: |
# eslint for linting
# - remove on Node.js < 10
if [[ "$(cut -d. -f1 <<< "${{ matrix.node-version }}")" -lt 10 ]]; then
# - remove on Node.js < 12
if [[ "$(cut -d. -f1 <<< "${{ matrix.node-version }}")" -lt 12 ]]; then
node -pe 'Object.keys(require("./package").devDependencies).join("\n")' | \
grep -E '^eslint(-|$)' | \
sort -r | \
Expand All @@ -148,12 +187,12 @@ jobs:
echo "node@$(node -v)"
echo "npm@$(npm -v)"
npm -s ls ||:
(npm -s ls --depth=0 ||:) | awk -F'[ @]' 'NR>1 && $2 { print "::set-output name=" $2 "::" $3 }'
(npm -s ls --depth=0 ||:) | awk -F'[ @]' 'NR>1 && $2 { print $2 "=" $3 }' >> "$GITHUB_OUTPUT"

- name: Run tests
shell: bash
run: |
if npm -ps ls istanbul | grep -q istanbul; then
if npm -ps ls nyc | grep -q nyc; then
npm run test-ci
else
npm test
Expand All @@ -165,7 +204,7 @@ jobs:

- name: Collect code coverage
uses: coverallsapp/github-action@master
if: steps.list_env.outputs.istanbul != ''
if: steps.list_env.outputs.nyc != ''
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
flag-name: run-${{ matrix.test_number }}
Expand All @@ -175,8 +214,8 @@ jobs:
needs: test
runs-on: ubuntu-latest
steps:
- name: Uploade code coverage
- name: Upload code coverage
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.github_token }}
github-token: ${{ secrets.GITHUB_TOKEN }}
parallel-finished: true
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
"eslint-plugin-node": "11.1.0",
"eslint-plugin-promise": "4.3.1",
"eslint-plugin-standard": "4.1.0",
"istanbul": "0.4.5",
"mocha": "9.1.0"
"mocha": "10.2.0",
"nyc": "15.1.0"
},
"files": [
"HISTORY.md",
Expand All @@ -33,9 +33,9 @@
"node": ">= 0.8"
},
"scripts": {
"lint": "eslint .",
"lint": "eslint --plugin markdown --ext js,md .",
"test": "mocha --reporter spec --bail --check-leaks test/",
"test-ci": "istanbul cover node_modules/mocha/bin/_mocha --report lcovonly -- --reporter spec --check-leaks test/",
"test-cov": "istanbul cover node_modules/mocha/bin/_mocha -- --reporter dot --check-leaks test/"
"test-ci": "nyc --reporter=lcov --reporter=text npm test",
"test-cov": "nyc --reporter=html --reporter=text npm test"
}
}
Loading