-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support upcoming changes in node #20
Conversation
Thanks, but I don't understand why the change is necessary. You can see on the README the expected object for what a user should be passing in. They shouldn't be passing in anything where the value is an array. |
The issue is that |
I mean, that sounds like those module are where the change belongs, because this module has never documented ever being able to pass in that object (also not tested). If those modules upstream wanted to take a short cut that was working, that's fine, but if their shortcut stopped working, they should change it there. Because even this, this PR would then be missing the documentation to document that the objects passed in could now take arrays, which once you document the API looks like that, it doesn't really even make sense any longer... |
Alright, will open a PR against |
Gotcha. I look at express with blame and it looks like express has done that basically forever, lol. I know I've seen usages of I know times where I have personally reached for Also, what version of Node.js is this change in (or is it just pending in a PR somewhere)? |
Node PR is at: nodejs/node#10558 You can still iterate over it (although it is private) like before, but the thing that changed is the value. Basically instead of storing the original cased header names in a separate object ( Currently the change is only in master and I've labeled it as semver-major now. So it would be in v8.0.0 at the earliest. |
FWIW I went ahead and submitted a PR to add a |
No description provided.