Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[FIX]] default to empty string in src/cli.js loadIgnores #2266

Merged
merged 1 commit into from
Apr 10, 2015
Merged

[[FIX]] default to empty string in src/cli.js loadIgnores #2266

merged 1 commit into from
Apr 10, 2015

Conversation

stringparser
Copy link
Contributor

Related to nodejs/node#1153.

They added type checking for path.dirname the path library and this line below fails

return path.join(path.dirname(file), line.trim());

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.33% when pulling 0eeba14 on stringparser:iojs-v1.6.0/lib/path.js-type-checking into 12811e7 on jshint:master.

@stringparser
Copy link
Contributor Author

ping

stringparser added a commit to stringparser/runtime that referenced this pull request Mar 25, 2015
rwaldron added a commit that referenced this pull request Apr 10, 2015
…pe-checking

[[FIX]] default to empty string in src/cli.js loadIgnores
@rwaldron rwaldron merged commit e762c76 into jshint:master Apr 10, 2015
@stringparser stringparser deleted the iojs-v1.6.0/lib/path.js-type-checking branch April 11, 2015 08:16
jugglinmike pushed a commit to jugglinmike/jshint that referenced this pull request Apr 12, 2015
….js-type-checking

[[FIX]] default to empty string in src/cli.js loadIgnores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants