Replace alloca with std::vector #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EagleTw
force-pushed
the
AddCommentWhileStudying
branch
from
638eeed to
022564e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jserv
reviewed
Nov 2, 2023
jserv
reviewed
Nov 2, 2023
EagleTw
force-pushed
the
AddCommentWhileStudying
branch
from
022564e to
339629e
Compare
jserv
requested changes
Nov 2, 2023
EagleTw
force-pushed
the
AddCommentWhileStudying
branch
from
c65a9b0 to
7074bb9
Compare
jserv
reviewed
Nov 2, 2023
The reason as follows: 1. The alloca() function is machine- and compiler-dependent. We should use machine independent container instead. 2. The alloca() function has stack overflow potentail. If the allocation causes stack overflow, program behavior is undefined.
EagleTw
force-pushed
the
AddCommentWhileStudying
branch
from
7074bb9 to
77556ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason as follows:
We should use machine independent container instead.
allocation causes stack overflow, program behavior is undefined.