Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Misc: set default value of maxErrors option to 50 #1508

Closed
wants to merge 1 commit into from

Conversation

markelog
Copy link
Member

@markelog markelog commented Jul 5, 2015

  • Set default value of maxErrors option to 50
  • Do not consider maxErrors value at autofix execution
  • Rename testsuites of root modules
    (since they should point to the path of module their testing)

Fixes #681

/cc @mikesherov @mdevils

* Set default value of maxErrors option to 50
* Do not consider maxErrors value at autofix execution
* Rename testsuites of root modules
  (since they should point to the path of module their testing)

Fixes jscs-dev#681
@mrjoelkemp
Copy link
Member

Not seeing new logic about how this prevents autofix from being affected. A test would suffice for reassurance.

Lgtm, but this is for sure a breaking change. So merge in the 2.0 branch? Still haven't heard if we're doing 2.0 first or 1.14.

@markelog
Copy link
Member Author

markelog commented Jul 5, 2015

A test would suffice for reassurance.

For sure, will add one

Lgtm, but this is for sure a breaking change. So merge in the 2.0 branch? Still haven't heard if we're doing 2.0 first or 1.14.

That is the question, isn't it :-). It is good thing that we have two branches, there is three things need to be done, in order to release 2.0:

  1. Execution without options #986
  2. Make jsDoc plugin part of the jscs dist #1359
  3. Supporting ES7/Babel #1353

#986 requires more discussion, so it might be closed as won't fix, others, mostly depend on free time of the @zxqfox and @hzoo.

It seems #1359 is pretty easy to do and @hzoo solved most of complicated issues of #1353, one little step left to do.

So i'm thinking, if we could do those three things quickly, like week at most, we might as well, release 2.0.

@hzoo
Copy link
Member

hzoo commented Jul 6, 2015

#1494 left on the actual 1.14 milestone but I'm assuming there might be a few more?

@mrjoelkemp
Copy link
Member

Thanks for the explanation @markelog. 2.0 on 7/14. Sounds like a plan.

@markelog markelog closed this in 16d6c06 Jul 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants