Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yak.js.org #9494

Merged
merged 3 commits into from
Jan 15, 2025
Merged

yak.js.org #9494

merged 3 commits into from
Jan 15, 2025

Conversation

Mad-Kat
Copy link
Contributor

@Mad-Kat Mad-Kat commented Jan 14, 2025 •
edited
Loading

Old PR: #8817

@indus indus changed the title Move yak.js.org from Github pages to Vercel yak.js.org Jan 14, 2025
@indus indus added user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages 404 The page requested returns a 404 response labels Jan 14, 2025
@indus
Copy link
Member

indus commented Jan 14, 2025

@Mad-Kat I think you have a typo in your PR as it ususally is cname.vercel-dns.com not name.vercel-dns.com. I've already made a change in JS.ORGs zone file to cname.vercel-dns.com but would like to ask you to update PR.

Besides that I'm getting a error 404. You may have to configure your host to accept the custom domain.
I'll merge after we have "contact". Please keep this PR open.

@Mad-Kat
Copy link
Contributor Author

Mad-Kat commented Jan 14, 2025

You're right. Sorry for the inconvenience and thank you for updating my PR.

I will look into the error tomorrow and give you a heads up when I think it should work.

@Mad-Kat
Copy link
Contributor Author

Mad-Kat commented Jan 15, 2025

I've added the domain to vercel and it looks like it works. Thank you very much

@indus indus removed the 404 The page requested returns a 404 response label Jan 15, 2025
@indus
Copy link
Member

indus commented Jan 15, 2025

Welcome back https://yak.js.org

@indus indus merged commit 2a01fec into js-org:master Jan 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mad-Kat @indus