Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream-regex.js.org #8865

Merged
merged 1 commit into from
Mar 3, 2024
Merged

stream-regex.js.org #8865

merged 1 commit into from
Mar 3, 2024

Conversation

musawirali
Copy link
Contributor

@MattIPv4 MattIPv4 changed the title Add stream-regex cname stream-regex.js.org Feb 29, 2024
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Feb 29, 2024
@musawirali
Copy link
Contributor Author

Hi @MattIPv4 . Thanks for the pointer. I've added the custom subdomain now.

@musawirali musawirali requested a review from MattIPv4 March 1, 2024 14:18
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/getjerry/stream-regex/tree/gh-pages

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Mar 1, 2024
@indus indus added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Mar 2, 2024
@indus
Copy link
Member

indus commented Mar 2, 2024

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@musawirali
Copy link
Contributor Author

@indus thank you. I've followed the comments you linked and it seems to be working!

@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Mar 3, 2024
@indus
Copy link
Member

indus commented Mar 3, 2024

Welcome https://stream-regex.js.org

@indus indus merged commit 85a51f3 into js-org:master Mar 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants