Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplyxp.js.org #8792

Merged
merged 1 commit into from
Jan 28, 2024
Merged

simplyxp.js.org #8792

merged 1 commit into from
Jan 28, 2024

Conversation

Abadima
Copy link
Contributor

@Abadima Abadima commented Jan 27, 2024

@MattIPv4 MattIPv4 changed the title Update cnames_active.js simplyxp.js.org Jan 27, 2024
@MattIPv4
Copy link
Member

@Rahuletto as the original requestor of this subdomain (#6760), please could you confirm you are okay with this change?

@MattIPv4 MattIPv4 added the awaiting response This PR is waiting for a response from the requester label Jan 27, 2024
@Rahuletto
Copy link
Contributor

Yea I'm good with it. I transfered the project to @Abadima 👍

Good to go!

MattIPv4
MattIPv4 requested changes Jan 27, 2024
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added awaiting CNAME This PR is waiting for the target to add a CNAME file and removed awaiting response This PR is waiting for a response from the requester labels Jan 27, 2024
@Abadima
Copy link
Contributor Author

Abadima commented Jan 27, 2024

done :)

@indus indus added organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Jan 28, 2024
@indus
Copy link
Member

indus commented Jan 28, 2024

Welcome back https://simplyxp.js.org/
(FYI: Looks like something is wrong with the paths)

@indus indus merged commit 323cda1 into js-org:master Jan 28, 2024
1 check passed
@Abadima
Copy link
Contributor Author

Abadima commented Jan 29, 2024

Patched the issue, thanks! 👍

@Abadima Abadima deleted the patch-1 branch January 29, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 requested changes

Assignees
No one assigned
Labels
change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Abadima @MattIPv4 @Rahuletto @indus