Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aries.js.org / credo.js.org #8782

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

TimoGlastra
Copy link
Contributor

We have moved the project docs hosted under aries.js.org to a new organization (from hyperledger to openwallet-foundation), and are also in the process of renaming the project to credo so we'd like to update the aries.js.org to credo.js.org

It's not ready to be merged yet (as we're in the process of renaming still), but I had a few questions with this move:

  1. Can we redirect aries.js.org to credo.js.org or is that not possible?
  2. Do we somehow need to verify the account ownership? The original PR for aries.js.org was also created by me (see aries.js.org #7347), and you can verify the move of organization by going to https://github.com/hyperledger/aries-javascript-docs and seeing you're redirect to https://github.com/openwallet-foundation/agent-javascript-docs (where a CNAME PR is opened by me, we will rename the repo to credo-ts-docs and merge that PR before this one should be merged)

Signed-off-by: Timo Glastra <[email protected]>
@indus
Copy link
Member

indus commented Jan 22, 2024

@TimoGlastra

  1. A repo can only have a single CNAME so keeping both subdomains is not possible. But for what I know Github redirects requests to properly transfered repos (as you mentioned in question 2). That may help but I'm not sure. I can try to keep the old subdomain targeting the old repo and we see if that gets redirected as well (In that case both records should be in our list).
    If it doesn't work you can also leave a micropage in a minimalistic repo that provides a button that brings users to your new repo (something like https://vue.js.org)

  2. As you have requested the subdomain initially you are entitled to change it (we only ask for approval if the requester changes or similar cases).

Give me a hint when you are ready. I'm only processing requests once or twice a day (so worst case it may take 24 hours) if you need less downtime we should make an appointment.

@indus indus added organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account change This PR/issue is regarding making a change to an existing subdomain on hold labels Jan 22, 2024
@indus indus changed the title chore: rename aries to credo aries.js.org / credo.js.org Jan 22, 2024
@TimoGlastra TimoGlastra marked this pull request as ready for review January 23, 2024 04:57
@TimoGlastra
Copy link
Contributor Author

TimoGlastra commented Jan 23, 2024

Thank you for the quick response!

I've updated the credo-ts-docs repo to now point to credo.js.org (see https://github.com/openwallet-foundation/credo-ts-docs/blob/gh-pages/CNAME)

I've also created a redirect page with CNAME pointing to aries.js.org: https://github.com/TimoGlastra/aries-credo-redirect/blob/main/CNAME

Funnily enough however, the moment I published the redirect page with the aries.js.org CNAME it was live (check for yourself at https://aries.js.org)? Even though it's not configured yet in the cnames_active.js. That seems odd?!

Anyway, this is ready to be merged now!

@indus indus added add This PR/issue is regarding adding a new subdomain and removed on hold labels Jan 23, 2024
@indus
Copy link
Member

indus commented Jan 23, 2024

Welcome back https://aries.js.org
Welcome https://credo.js.org

@indus indus merged commit f5f46e1 into js-org:master Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain change This PR/issue is regarding making a change to an existing subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants