Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discord-mini-games.js.org #8762

Merged
merged 4 commits into from
Jan 12, 2024
Merged

discord-mini-games.js.org #8762

merged 4 commits into from
Jan 12, 2024

Conversation

TanvishGG
Copy link
Contributor

@TanvishGG TanvishGG commented Jan 12, 2024

This is for docs of my npm packages,

Thank you.
packages:
text-encryption-tool
discord-mini-games.js

Repo: https://github.com/TanvishGG/docs

@MattIPv4 MattIPv4 changed the title Update cnames_active.js tanvish.js.org Jan 12, 2024
@MattIPv4
Copy link
Member

@indus to me, this falls under what I'd consider to be a personal site? It's a collection of different sets of documentation for packages created by the user. I'd expect a dedicated subdomain with docs for each package, rather than a subdomain dedicated to the user?

@MattIPv4 MattIPv4 added the awaiting response This PR is waiting for a response from the requester label Jan 12, 2024
@TanvishGG
Copy link
Contributor Author

i can dedicate subdomain to each package, but what i thought was this can reduce number of subdomains

@indus
Copy link
Member

indus commented Jan 12, 2024

I see two unrelated projects (Discord-Mini-Games & Text Encryption) with a minimal documentation.

I think it is best to use two subdomains. Something like:
discord-mini-games.js.org and text-encryption.js.org

@TanvishGG You may want to modify one and open another for the other package...

@TanvishGG
Copy link
Contributor Author

TanvishGG commented Jan 12, 2024

@indus I've updated this to discord-mini-games.js.org
https://github.com/TanvishGG/discord-mini-games-docs
Since, text-encryption-tool needs minimal docs, I'll let it be for now.

@indus indus changed the title tanvish.js.org discord-mini-games.js.org Jan 12, 2024
@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account awaiting CNAME This PR is waiting for the target to add a CNAME file and removed awaiting response This PR is waiting for a response from the requester labels Jan 12, 2024
@indus
Copy link
Member

indus commented Jan 12, 2024

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@TanvishGG
Copy link
Contributor Author

@indus im sorry for the trouble, on a second thought I've merged the docs repo to the main repo itself
So it'll be same but from tanvishgg.github.io/Discord-Mini-Games.js. and I'm using the default GitHub pages now instead of actions,
Thank you.

@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Jan 12, 2024
@indus
Copy link
Member

indus commented Jan 12, 2024

Welcome https://discord-mini-games.js.org

@indus indus merged commit a447158 into js-org:master Jan 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants