Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miru.js.org #8169

Merged
merged 2 commits into from
Apr 14, 2023
Merged

miru.js.org #8169

merged 2 commits into from
Apr 14, 2023

Conversation

MiaoMint
Copy link
Contributor

@indus indus added the awaiting response This PR is waiting for a response from the requester label Apr 13, 2023
@indus
Copy link
Member

indus commented Apr 13, 2023

I'm having trouble to get what the page is about. Please help me out and give me an abstract.
Another issue is that you are using the CNAME twice: https://github.com/MiaoMint/miru-docs/blob/main/CNAME
That may cause conflicts.

@MiaoMint
Copy link
Contributor Author

Thanks for your reply, this is an introduction and development document about https://github.com/miru-project/miru-next (https://miru.0u0.ren/). I have solved the CNAME problem.

@MiaoMint MiaoMint closed this Apr 13, 2023
@MiaoMint MiaoMint reopened this Apr 13, 2023
@indus
Copy link
Member

indus commented Apr 13, 2023

Thanks for your reply, this is an introduction and development document about https://github.com/miru-project/miru-next (https://miru.0u0.ren/). I have solved the CNAME problem.

That is not that much information. "miru-next" looks like some sort of content distribution website. That makes me wonder about the licenses. That may be not an issue for a documentation website, but it makes me wonder how this is related to the Javascript and would be a benefit for the JS community?!

@MiaoMint
Copy link
Contributor Author

Thanks for your reply, this is an introduction and development document about https://github.com/miru-project/miru-next (https://miru.0u0.ren/). I have solved the CNAME problem.

That is not that much information. "miru-next" looks like some sort of content distribution website. That makes me wonder about the licenses. That may be not an issue for a documentation website, but it makes me wonder how this is related to the Javascript and would be a benefit for the JS community?!

This project is not a content distribution site, it doesn't store content itself, it's a multi-functional player/media manager that relies on user-made JavaScript extensions to implement content.

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account awaiting CNAME This PR is waiting for the target to add a CNAME file and removed awaiting response This PR is waiting for a response from the requester labels Apr 13, 2023
@indus
Copy link
Member

indus commented Apr 13, 2023

Thanks for that explanation - that sounds reasonable to me.
I've already added your requested subdomain to JS.ORGs zonefile. But as you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI: #7853 (comment)

@MiaoMint
Copy link
Contributor Author

Thank you, I have solved the problem according to your help and now it is working properly

@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Apr 14, 2023
@indus
Copy link
Member

indus commented Apr 14, 2023

Welcome https://miru.js.org

@indus indus merged commit 80e52da into js-org:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants