Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stamps.js.org #7860

Merged
merged 2 commits into from
Dec 12, 2022
Merged

stamps.js.org #7860

merged 2 commits into from
Dec 12, 2022

Conversation

ronald-cognite
Copy link
Contributor

@ronald-cognite ronald-cognite commented Dec 8, 2022

Project repository: https://github.com/Ronald-Baars/stamps

@indus indus changed the title add stamps.js.org stamps.js.org Dec 8, 2022
@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account awaiting CNAME This PR is waiting for the target to add a CNAME file labels Dec 8, 2022
@indus
Copy link
Member

indus commented Dec 8, 2022

I've already added your requested subdomain to JS.ORGs zonefile. But as you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI: #7853 (comment)

@ronald-cognite
Copy link
Contributor Author

Thanks @indus! I'll check it out

@ronald-cognite
Copy link
Contributor Author

FYI: I solved it by changing the GitHub workflow file to do this:

yarn next build && touch ./out/CNAME && echo \"stamps.js.org\" >> ./out/CNAME

in stead of

yarn next build

@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Dec 12, 2022
@indus
Copy link
Member

indus commented Dec 12, 2022

Welcome https://stamps.js.org

@indus indus merged commit 0cb1b0c into js-org:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants