Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook-addon-playroom.js.org #5282

Merged
merged 1 commit into from
Dec 28, 2020
Merged

storybook-addon-playroom.js.org #5282

merged 1 commit into from
Dec 28, 2020

Conversation

rbardini
Copy link
Contributor

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

Before we can accept your js.org domain request, your site must have reasonable content. ❌
Based on https://storybook-addon-playroom.netlify.app/ your site appears to currently not contain what we would consider to be reasonable content to grant a request, it appears to be a basically unmodified instance of storybook.

Please see the wiki article: https://github.com/js-org/js.org/wiki/No-Content 📖

@MattIPv4 MattIPv4 added the no content This PR has a target that contains no valid content for a request label Dec 28, 2020
@rbardini
Copy link
Contributor Author

Hi @MattIPv4! This is the demo website for rbardini/storybook-addon-playroom, an Storybook instance configured with the Playroom addon:

Demo

I just updated the branding and panels to make that clearer (GIF is outdated), hope it's better 🙂

Relates to #5254.

@rbardini rbardini requested a review from MattIPv4 December 28, 2020 12:25
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, site has content based on https://storybook-addon-playroom.netlify.app/

I trust that your netlify is configured ready to work with the requested js.org subdomain.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages and removed no content This PR has a target that contains no valid content for a request labels Dec 28, 2020
@indus
Copy link
Member

indus commented Dec 28, 2020

Welcome https://storybook-addon-playroom.js.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants