-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python versions in pipeline #910
Conversation
Updates Python 3.7.5 to 3.7.7 and 3.8.0 to 3.8.2. Also add the alpha 5 build of Python 3.9 as an allowable failure.
1d81841
to
0575def
Compare
@@ -96,7 +98,7 @@ jobs: | |||
python: 3.7 | |||
env: | |||
<<: *env_windows | |||
JRNL_PYTHON_VERSION: 3.7.5 | |||
JRNL_PYTHON_VERSION: 3.7.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this PR update Python versions for all OSes instead of just Windows? Best to keep them all updated at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know where to find a list of the MasOS versions available? Windows versions are coming from Chocolatey, but I'd assumed that the MacOS versions were tied to the base image...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@micahellison It looks like you can use Homebrew to install custom versions of Python, but that is beyond my experience... see http://www.pyslvs.com/blog/yuan_2018-09-22.html
The Travis documentation doesn't actually say what Python versions are available on what OSX images, just that at least one Python version will always be available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the Mac builds, you can set JRNL_PYTHON_VERSION
without having to modify anything else. Python comes pre-installed on macOS, so the build uses pyenv install
to install whatever version the JRNL_PYTHON_VERSION
is set to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
@wren @micahellison updated, as requested (other than the MacOS versions). Changing the MacOS Python versions requires switching to Homebrew for installing Python, which is beyond my expertise. This should be good to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* [Travis] update Windows Python versions * Update Python versions to be uniform across the board Co-authored-by: Jonathan Wren <[email protected]>
* [Travis] update Windows Python versions * Update Python versions to be uniform across the board Co-authored-by: Jonathan Wren <[email protected]>
* [Travis] update Windows Python versions * Update Python versions to be uniform across the board Co-authored-by: Jonathan Wren <[email protected]>
Updates Python 3.7.5 to 3.7.7 and 3.8.0 to 3.8.2.
Also add the alpha 5 build of Python 3.9 as an allowable failure.Poetry doesn't support Python 3.9 yet. See python-poetry/poetry#2154Checklist