Test with the right Django version ; Add and fix 1.9 tests #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roidelapluie
force-pushed
the
fix-test-django-version
branch
from
929c6f2 to
0d88a23
Compare
Prior to this commit, the tests were running with Django 1.8 because it is in requirements.txt, which was installed after the specific version of Django. This commit inverts that order, allowing the defined version of Django to be used for testing.
roidelapluie
force-pushed
the
fix-test-django-version
branch
4 times, most recently
from
69bc39b to
deb9203
Compare
Closed
roidelapluie
changed the title
Also update django-websockets version in requirements.txt
roidelapluie
force-pushed
the
fix-test-django-version
branch
2 times, most recently
from
1aa5d5c to
50b48b3
Compare
|
@jrief is there somthing blocking this PR? |
|
@roidelapluie could you just update Django versions to 1.8.8 and 1.9.1? |
|
Done |
|
It is failing for Python 3.3 and Django 1.9.1. Since Django 1.9 only supports python 3.4 & 3.5, I guess you can simply remove testing for python 3.3 under Django 1.9 |
roidelapluie
force-pushed
the
fix-test-django-version
branch
from
690004b to
507b4b2
Compare
|
Sorry, it was there for 1.9, not 1.9.1. Amended and fixed. |
roidelapluie
force-pushed
the
fix-test-django-version
branch
from
507b4b2 to
4b26531
Compare
nanuxbe
added a commit
that referenced
this pull request
Jan 4, 2016
Test with the right Django version ; Add and fix 1.9 tests
|
thanks @roidelapluie :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the tests were running with Django 1.8 because it
is in requirements.txt, which was installed after the specific version
of Django.
This commit inverts that order, allowing the defined version of Django
to be used for testing.