switch to libjpeg-turbo as jpeg library
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
libjpeg is also maintained, though maybe not that actively, since it's only an update every two years, the latest being last January. But faster is better, and it does seem most everyone else has switched. You need to also remove the jpeg repository at the top of each file. |
Ah, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the Linux distributions have switched to libjpeg-turbo as their upstream a long time ago, as this one is actively maintained and much much faster too.
The reason why I didn't submit this PR earlier is that we had some rpath issues that needed resolving: Xpra-org#19 (comment) - big thanks to @cpatulea for figuring out that we needed a
DCMAKE_INSTALL_NAME_DIR.We've been running xpra with
libjpeg-turbofor many years without issues - well, apart from the manualrpathfixup...