Skip to content
This repository has been archived by the owner on Dec 11, 2021. It is now read-only.

[WIP] Add jsass variables to typography #134

Closed
wants to merge 2 commits into from
Closed

[WIP] Add jsass variables to typography #134

wants to merge 2 commits into from

Conversation

theutahkate
Copy link

fixes gh-119
replaces pr #129

coauthored with @xtinastarr

I believe the tags are the only ones left to do here.

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

"code": {
name: "Code",
value: {
"background": "$code-background",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant?? Should use only one? either code-background or inside a map. And since you seem to use maps everywhere might as well stick to maps here too.

@geekman-rohit
Copy link
Contributor

@arschmitz regarding the indentation not being validated, we will have to wait for grunt-jscs to update to version 2.5.1 of node-jscs before doing a version bump at our repo.
jscs-dev/grunt-jscs#104

Umm I correct myself:
that commit was reverted it seems jscs-dev/node-jscs@056770d

@sfrisk
Copy link
Contributor

sfrisk commented Dec 15, 2015

Hey @theutahkate @xtinastarr! Just checking in on the status of this PR.

@geekman-rohit
Copy link
Contributor

@theutahkate updates?

@sfrisk
Copy link
Contributor

sfrisk commented Jan 12, 2016

Haven't heard any status update on this in awhile, so I'm closing this.

@sfrisk sfrisk closed this Jan 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typography: Add jsass variables to typography
5 participants