fix: string().notRequired() (#1824)

jquense · Nov 7, 2022 · dcb4b63 · dcb4b63
1 parent 6250a14
commit dcb4b63
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/string.ts b/src/string.ts
@@ -97,7 +97,7 @@ export default class StringSchema<
 
   notRequired() {
     return super.notRequired().withMutation((schema: this) => {
-      schema.tests.filter((t) => t.OPTIONS!.name !== 'required');
+      schema.tests = schema.tests.filter((t) => t.OPTIONS!.name !== 'required');
       return schema;
     });
   }

diff --git a/test/string.ts b/test/string.ts
@@ -94,6 +94,15 @@ describe('String types', () => {
     ]);
   });
 
+  it('should handle NOTREQUIRED correctly', function () {
+    let v = string().required().notRequired();
+
+    return Promise.all([
+      expect(v.isValid(undefined)).resolves.toBe(true),
+      expect(v.isValid('')).resolves.toBe(true),
+    ]);
+  });
+
   it('should check MATCHES correctly', function () {
     let v = string().matches(/(hi|bye)/, 'A message');