Add !default
suffix to all Sass variables
#410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to
lessToSass.js
adds!default
after the end of all variables in Sass files.One thing that I really like about Sass is variable defaults, so that variables can be defined once at the beginning before importing dependencies instead of having to override variables after the fact. LESS instead has "lazy loading" of variables which makes it technically unneccessary to have defaults, but also causes a lot of confusion about the way LESS vs Sass handle their variables. LESS variables are a lot like Javascript hoisting, which tends to rub me the wrong way. Call me old fashioned, but I just prefer a nice simple top-down variable definition.
For example instead of needing to do this (via
sass-loader
in Webpack, hence the use of~
):It can be replaced with a much more compact import:
Similar to how someone might do this with LESS and its lazy loading (via
less-loader
):