Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for React v18.x.x #2176

Merged
merged 1 commit into from
May 18, 2022

Conversation

philipp-michelfeit
Copy link
Contributor

Added support for React v18.x.x

@cutterbl
Copy link
Collaborator

@philipp-michelfeit Have you actually tested Big Calendar with React 18?

@philipp-michelfeit
Copy link
Contributor Author

@cutterbl yeah and it runs well

@bartvanandel bartvanandel merged commit 8e4fafa into jquense:master May 18, 2022
@aotimme
Copy link

aotimme commented Jun 1, 2022

Do you know when this will show up in the next release to npm? It looks like the peer dependency is still set to react@"^16.14.0 || ^17" in what's on npm:

$ npm i --save react-big-calendar
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^18.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.14.0 || ^17" from [email protected]
npm ERR! node_modules/react-big-calendar
npm ERR!   react-big-calendar@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/me/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/me/.npm/_logs/2022-06-01T21_44_21_551Z-debug.log

For now this can be worked around using the --legacy-peer-deps flag:

npm install --save --legacy-peer-deps react-big-calendar

But ideally the code on npm would have the updated peer dependency version.

Thank you!

@pmichelfeit
Copy link

You can also use the --force option !

@popuguytheparrot
Copy link

release?

@github-actions
Copy link

🎉 This PR is included in version 0.40.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants