Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/fix all custom components documentation #2014

Merged
merged 4 commits into from
Aug 28, 2021
Merged

Docs/fix all custom components documentation #2014

merged 4 commits into from
Aug 28, 2021

Conversation

khendrikse
Copy link
Contributor

@khendrikse khendrikse commented Aug 26, 2021

Me and my colleagues had a hard time figuring out what was possible with the library. I dove into the source code and realised that there was a bunch of documentation, but it was not rendering.

The docs that I moved from the top of the Calendar.js file: I don't know if these pieces of information are still relevant, but I added them to the intro. They were not rendering at all before.

I also added a comma so the custom component docs would render properly, and I added more info on the messages.

Might help solve:

Before:

image

image

After:

image

image

@jquense
Copy link
Owner

jquense commented Aug 27, 2021

thanks!

@khendrikse
Copy link
Contributor Author

thanks!

Most welcome!

@jquense jquense merged commit d695d0a into jquense:master Aug 28, 2021
@ssusanto2706
Copy link

Could you make an example for the the custom components?

@github-actions
Copy link

🎉 This PR is included in version 0.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants