Make field colors configurable #2638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow object key colors to be configured with the "JQ_COLORS" environment variable. This is a updated version of a [GitHub pull request created by David Haguenauer](#1791). Since the prebuilt manual already needed to be updated, this change also fixes in omission in <cf61515> in which "39" in "JQ_COLORS" should have been replaced with "37".
|
I also wrote a script called jqcolors that's analagous to dircolors that I could include in a separate PR if you'd accept it: https://github.com/ericpruitt/emus/blob/master/scripts/jqcolors. Example file: |
itchyny
requested changes
Jun 29, 2023
| @@ -293,20 +293,44 @@ if [ "$($VALGRIND $Q $JQ -n '{"a":"xyz"} | halt_error(1)' 2>&1)" != '{"a":"xyz"} | |||
| fi | |||
|
|
|||
| # Check $JQ_COLORS | |||
| ## Default colors, null input | |||
| $JQ -Ccn . > $d/color | |||
There was a problem hiding this comment.
Please prepend JQ_COLORS= this line and L307. make check fails when exporting the environment variable.
| @@ -13,7 +13,8 @@ typedef enum { | |||
| JV_KIND_NUMBER, | |||
| JV_KIND_STRING, | |||
| JV_KIND_ARRAY, | |||
| JV_KIND_OBJECT | |||
| JV_KIND_OBJECT, | |||
| JV_KIND_FIELD | |||
There was a problem hiding this comment.
Please see #1791 (comment).
itchyny
added a commit
to itchyny/jq
that referenced
this pull request
Jul 12, 2023
itchyny
added a commit
to itchyny/jq
that referenced
this pull request
Jul 12, 2023
itchyny
added a commit
to itchyny/jq
that referenced
this pull request
Jul 12, 2023
itchyny
added a commit
to itchyny/jq
that referenced
this pull request
Jul 12, 2023
…qlang#2638) Co-authored-by: David Haguenauer <[email protected]> Co-authored-by: Eric Pruitt <[email protected]>
itchyny
added a commit
to itchyny/jq
that referenced
this pull request
Jul 12, 2023
…qlang#2638) Co-authored-by: David Haguenauer <[email protected]> Co-authored-by: Eric Pruitt <[email protected]>
itchyny
added a commit
to itchyny/jq
that referenced
this pull request
Jul 12, 2023
…qlang#2638) Co-authored-by: David Haguenauer <[email protected]> Co-authored-by: Eric Pruitt <[email protected]>
nicowilliams
pushed a commit
that referenced
this pull request
Jul 18, 2023
Co-authored-by: David Haguenauer <[email protected]> Co-authored-by: Eric Pruitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow object key colors to be configured with the "JQ_COLORS" environment variable. This is a updated version of a GitHub pull request created by David
Haguenauer. Since the prebuilt manual already needed to be updated, this change also fixes in omission in cf61515 in which "39" in "JQ_COLORS" should have been replaced with "37".