Validate module metadata to be an object #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Ah, can you rebase and re-gen the bison outputs? |
itchyny
force-pushed
the
fix-module-metadata-validation
branch
from
0a3115b to
87f994a
Compare
|
Do I need to use older version of Bison? |
No. Any version will do provided it works. |
|
Thank you. I rebased and confirmed |
itchyny
force-pushed
the
fix-module-metadata-validation
branch
from
87f994a to
939ddd9
Compare
|
Sorry, I rebased again to generate by the latest Bison (3.8.2). |
itchyny
force-pushed
the
fix-module-metadata-validation
branch
from
939ddd9 to
ac752e1
Compare
itchyny
force-pushed
the
fix-module-metadata-validation
branch
from
ac752e1 to
3acfd04
Compare
wader
approved these changes
Jun 28, 2023
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module metadata should be an object so we should validate module directive just as import directive.