Skip to content

Commit

Permalink
Remove unnecessary definition of encoder count
Browse files Browse the repository at this point in the history
the value is calculated by QMK
  • Loading branch information
jpskenn committed Nov 3, 2023
1 parent 23b82ce commit a41653a
Show file tree
Hide file tree
Showing 9 changed files with 6 additions and 15 deletions.
3 changes: 0 additions & 3 deletions keyboards/sandy/dn0020/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
// when turn knob clockwise or counterclockwise.
// This is handy to assign key codes by VIA.

// Number of encoder
#define ENCODERS 2

/* RGB LED */
#define RGBLIGHT_DEFAULT_VAL 80
/*== Lighting Layers ==*/
Expand Down
2 changes: 1 addition & 1 deletion keyboards/sandy/dn0020/keymaps/jpskenn/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
// Rotary Encoder with VIA
//------------------------------------------------------------------------------
#ifdef ENCODER_MAP_ENABLE
const uint16_t PROGMEM encoder_map[][ENCODERS][2] = {
const uint16_t PROGMEM encoder_map[][NUM_ENCODERS][2] = {
[_BASE1] = { ENCODER_CCW_CW(KC_VOLU, KC_VOLD), ENCODER_CCW_CW(KC_VOLU, KC_VOLD) },
[_BASE2] = { ENCODER_CCW_CW(_______, _______), ENCODER_CCW_CW(_______, _______) },
[_BASE3] = { ENCODER_CCW_CW(_______, _______), ENCODER_CCW_CW(_______, _______) },
Expand Down
2 changes: 1 addition & 1 deletion keyboards/sandy/dn0020/keymaps/via/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
// Rotary Encoder with VIA
//------------------------------------------------------------------------------
#ifdef ENCODER_MAP_ENABLE
const uint16_t PROGMEM encoder_map[][ENCODERS][2] = {
const uint16_t PROGMEM encoder_map[][NUM_ENCODERS][2] = {
[_BASE1] = { ENCODER_CCW_CW(KC_VOLU, KC_VOLD), ENCODER_CCW_CW(KC_VOLU, KC_VOLD) },
[_BASE2] = { ENCODER_CCW_CW(_______, _______), ENCODER_CCW_CW(_______, _______) },
[_BASE3] = { ENCODER_CCW_CW(_______, _______), ENCODER_CCW_CW(_______, _______) },
Expand Down
3 changes: 0 additions & 3 deletions keyboards/sandy/dn0030/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
// when turn knob clockwise or counterclockwise.
// This is handy to assign key codes by VIA.

// Number of encoder
#define ENCODERS 2

/* RGB LED */
#define RGBLIGHT_DEFAULT_VAL 80
/*== Lighting Effects ==*/
Expand Down
2 changes: 1 addition & 1 deletion keyboards/sandy/dn0030/keymaps/jpskenn/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
// Rotary Encoder with VIA
//------------------------------------------------------------------------------
#ifdef ENCODER_MAP_ENABLE
const uint16_t PROGMEM encoder_map[][ENCODERS][2] = {
const uint16_t PROGMEM encoder_map[][NUM_ENCODERS][2] = {
[_BASE1] = { ENCODER_CCW_CW(KC_VOLU, KC_VOLD), ENCODER_CCW_CW(KC_VOLU, KC_VOLD) },
[_BASE2] = { ENCODER_CCW_CW(_______, _______), ENCODER_CCW_CW(_______, _______) },
[_BASE3] = { ENCODER_CCW_CW(_______, _______), ENCODER_CCW_CW(_______, _______) },
Expand Down
2 changes: 1 addition & 1 deletion keyboards/sandy/dn0030/keymaps/via/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
// Rotary Encoder with VIA
//------------------------------------------------------------------------------
#ifdef ENCODER_MAP_ENABLE
const uint16_t PROGMEM encoder_map[][ENCODERS][2] = {
const uint16_t PROGMEM encoder_map[][NUM_ENCODERS][2] = {
[_BASE1] = { ENCODER_CCW_CW(KC_VOLU, KC_VOLD), ENCODER_CCW_CW(KC_VOLU, KC_VOLD) },
[_BASE2] = { ENCODER_CCW_CW(_______, _______), ENCODER_CCW_CW(_______, _______) },
[_BASE3] = { ENCODER_CCW_CW(_______, _______), ENCODER_CCW_CW(_______, _______) },
Expand Down
3 changes: 0 additions & 3 deletions keyboards/sandy/v01/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
// when turn knob clockwise or counterclockwise.
// This is handy to assign key codes by VIA.

// Number of encoder
#define ENCODERS 2

/* RGB LED */
#define RGBLIGHT_DEFAULT_VAL 80
/*== Lighting Layers ==*/
Expand Down
2 changes: 1 addition & 1 deletion keyboards/sandy/v01/keymaps/jpskenn/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
// Rotary Encoder with VIA
//------------------------------------------------------------------------------
#ifdef ENCODER_MAP_ENABLE
const uint16_t PROGMEM encoder_map[][ENCODERS][2] = {
const uint16_t PROGMEM encoder_map[][NUM_ENCODERS][2] = {
[_BASE1] = { ENCODER_CCW_CW(KC_VOLU, KC_VOLD), ENCODER_CCW_CW(KC_VOLU, KC_VOLD) },
[_BASE2] = { ENCODER_CCW_CW(_______, _______), ENCODER_CCW_CW(_______, _______) },
[_BASE3] = { ENCODER_CCW_CW(_______, _______), ENCODER_CCW_CW(_______, _______) },
Expand Down
2 changes: 1 addition & 1 deletion keyboards/sandy/v01/keymaps/via/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
// Rotary Encoder with VIA
//------------------------------------------------------------------------------
#ifdef ENCODER_MAP_ENABLE
const uint16_t PROGMEM encoder_map[][ENCODERS][2] = {
const uint16_t PROGMEM encoder_map[][NUM_ENCODERS][2] = {
[_BASE1] = { ENCODER_CCW_CW(KC_VOLU, KC_VOLD), ENCODER_CCW_CW(KC_VOLU, KC_VOLD) },
[_BASE2] = { ENCODER_CCW_CW(_______, _______), ENCODER_CCW_CW(_______, _______) },
[_BASE3] = { ENCODER_CCW_CW(_______, _______), ENCODER_CCW_CW(_______, _______) },
Expand Down

0 comments on commit a41653a

Please sign in to comment.