Skip to content

Commit

Permalink
runtime: skip TestSegv traceback check on 386
Browse files Browse the repository at this point in the history
The VDSO (__kernel_vsyscall) is reachable via
asmcgocall(cgo_start_thread) on linux-386, which causes traceback to
throw.

Fixes golang#49182.
For golang#50504.

Change-Id: Idb78cb8de752203ce0ed63c2dbd2d12847338688
Reviewed-on: https://go-review.googlesource.com/c/go/+/376656
Reviewed-by: Cherry Mui <[email protected]>
Trust: Michael Pratt <[email protected]>
Run-TryBot: Michael Pratt <[email protected]>
  • Loading branch information
prattmic authored and jproberts committed Jun 21, 2022
1 parent 13a9f1a commit f7746f5
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions src/runtime/crash_cgo_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -625,12 +625,20 @@ func TestSegv(t *testing.T) {
// TODO(golang.org/issue/49182): Skip, runtime
// throws while attempting to generate
// traceback.
default:
nowant := "runtime: "
if strings.Contains(got, nowant) {
t.Errorf("unexpectedly saw %q in output", nowant)
return
case "linux":
if runtime.GOARCH == "386" {
// TODO(golang.org/issue/50504): Skip,
// runtime throws while attempting to
// generate traceback from VDSO call
// via asmcgocall.
return
}
}
nowant := "runtime: "
if strings.Contains(got, nowant) {
t.Errorf("unexpectedly saw %q in output", nowant)
}
})
}
}
Expand Down

0 comments on commit f7746f5

Please sign in to comment.