Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve filter option in copySync #424

Closed
wants to merge 1 commit into from
Closed

Conversation

manidlou
Copy link
Collaborator

@manidlou manidlou commented May 8, 2017

Applied the improved filter option that introduced in #423 to copySync().

Also cleaned up copySync a bit including:

  • removed recursive option. This option never been documented and had no use.
  • Add copyFileSync() as a function and wrap everything in one file since the entire file is just 114 lines!

In addition, removed option.overwrite = false in moveSync() since one of the tests (when move directory and overwrite is true) wouldn't pass. It was weird though as it would pass before! 😕 IDK! maybe because of the closure! After all, I guess it's better to remove that line though. Please correct me if I am wrong 😬

@manidlou manidlou requested review from jprichardson and RyanZim May 8, 2017 07:56
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 86.511% when pulling 56c814e on filter-copySync into 44eb2c3 on master.

@manidlou
Copy link
Collaborator Author

manidlou commented Sep 6, 2017

closing this since filter option is going through major changes in rewrite of copy that will affect copySync as well because of consistency.

@manidlou manidlou closed this Sep 6, 2017
@manidlou manidlou deleted the filter-copySync branch September 6, 2017 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants