Small fixes for fsspec backend, Enable fsspec tests for s3fs and smb #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
painebot
force-pushed
the
tkp/fsspectests
branch
2 times, most recently
from
5e3a5f9 to
da66bcc
Compare
painebot
force-pushed
the
tkp/fsspectests
branch
from
da66bcc to
a2f41b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#238 (comment)
Fixes a few small things, I suspect all of these were because i started from the fsspec implementation that had bitrotted a bit (due to our slowness in getting to it).