Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client version (1.7.3) differs from server version (v1.7.3) #228

Closed
matti opened this issue Dec 16, 2020 · 11 comments
Closed

Client version (1.7.3) differs from server version (v1.7.3) #228

matti opened this issue Dec 16, 2020 · 11 comments
Labels

Comments

@matti
Copy link

matti commented Dec 16, 2020

spams the logs like this

@deepseapenguin
Copy link

same issue here, I'm using docker image on aws server

@jpillora
Copy link
Owner

The version string is set using the commit tag, so it should be v1.X.X - are the client and server using the same binary?

@matti
Copy link
Author

matti commented Dec 22, 2020

in my case I'm running jpillora/chisel on server and brew installed client on the mac

@jpillora
Copy link
Owner

jpillora commented Dec 22, 2020 via email

@jpillora
Copy link
Owner

brew install chisel
Updating Homebrew...
==> Downloading https://homebrew.bintray.com/bottles/chisel-2.0.1.big_sur.bottle.tar.gz

https://formulae.brew.sh/formula/chisel is another app. How did you install with chisel?

@tralafiti
Copy link

I'm seeing this, too:

2022/03/02 18:13:26 server: session#12: Client version (1.7.7) differs from server version (v1.7.7)

Server is using the docker image:

docker run --rm -it jpillora/chisel --help                

  Usage: chisel [command] [--help]

  Version: v1.7.7 (go1.17.6)

Client downloaded the binary directly from Github:

./chisel_1.7.7_darwin_arm64 --help

  Usage: chisel [command] [--help]

  Version: 1.7.7 (go1.17.6)

I'm not sure, but maybe this is related to .github/goreleaser.yml#L8 using {{.Version}} which according to goreleaser gets stripped of v prefixes?

@matti
Copy link
Author

matti commented Mar 3, 2022 via email

@Montralis
Copy link

Is this still relevant?

@tralafiti
Copy link

Yes, issue still persists, but now the docker image is missing all version info:

% ./chisel_1.10.0_darwin_arm64 -version
1.10.0

% docker run --rm -it jpillora/chisel:1.10.0 -version


% docker run --rm -it jpillora/chisel:1.10.0 -help

  Usage: chisel [command] [--help]

  Version:  (go1.22.5)
...

Upon connecting:

2024/09/20 10:24:39 server: session#1: Client version (<unknown>) differs from server version (1.10.0)

@jpillora
Copy link
Owner

Ahh will fix

@tralafiti
Copy link

tralafiti commented Oct 2, 2024

Thank you! Docker Images now contain a version string again.

But I fear we are back to the start of the ticket: Docker-Image reports it's version prefixed with a v while the binaries from the release page report a version without this prefix, as described in #228 (comment) resulting in version miss-match log entries.

NewtonMan pushed a commit to OutSystems/chisel that referenced this issue Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants