Add amplitude discriminator parameter for extrema type (peak or trough), and epoch annotation for SpikeTrain #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `type` parameter allows the default types (peaks for amplitude windows with positive bounds; troughs for negative bounds) to be overridden. It also permits amplitude windows spanning zero (negative lower bound and positive upper bound), for which the type cannot be inferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
typeparameter allows the default types (peaks for amplitude windows with positive bounds; troughs for negative bounds) to be overridden. It also permits amplitude windows spanning zero (negative lower bound and positive upper bound), for which the type cannot be inferred automatically. See the documentation for details.This PR also adds an
"epoch"annotation to a detected spike train if the amplitude discriminator filtered the spikes by epoch type.