Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore video_file if PyAV is not installed #231

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Ignore video_file if PyAV is not installed #231

merged 1 commit into from
Mar 2, 2020

Conversation

jpgill86
Copy link
Owner

@jpgill86 jpgill86 commented Mar 2, 2020 •
edited
Loading

This change improves the viability of installing via pip (instead of conda), which does not provide PyAV.

Closes #200

@jpgill86 jpgill86 added the enhancement New feature or request label Mar 2, 2020
@jpgill86 jpgill86 added this to the 1.4.0 milestone Mar 2, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 63.419% when pulling 98e8dd4 on pyav-not-installed into 55379fd on master.

@coveralls
Copy link

coveralls commented Mar 2, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.07%) to 63.43% when pulling 98e8dd4 on pyav-not-installed into 55379fd on master.

@jpgill86 jpgill86 merged commit f342e18 into master Mar 2, 2020
@jpgill86 jpgill86 deleted the pyav-not-installed branch March 2, 2020 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Make PyAV optional
2 participants
@jpgill86 @coveralls