Move RAUC calculations to load_dataset and store them as annotations #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates the ``rauc_sigs`` parameter from ``EphyviewerConfigurator`` and ``EphyviewerConfiguratorWidget``.
Previously, the calculation of RAUCs was handled by orphan code executed after ``load_dataset``, duplicated in two files. This change moves that code into ``load_datasets``.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the calculation of the rectified area under the curve (RAUC) for AnalogSignals was handled by orphan code executed after
load_dataset, was duplicated in two files, and required that RAUCs be calculated manually in notebooks or interactive sessions, creating extra work for users.This change moves that code into
load_datasetso that it's handled automatically. The RAUC signals are stored as annotations in the returned Neo Block, attached to the original AnalogSignals that they are derived from.API change: Because the RAUCs are now stored as annotations in the Neo Block returned by
load_dataset, they no longer need to be passed separately in a list toEphyviewerConfiguratorandEphyviewerConfiguratorWidget. Consequently, therauc_sigsparameter has been removed from these class.