Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API parameters and CLI argument for displaying the real-world date and time #110

Merged
merged 4 commits into from
Aug 1, 2019
Merged

Add API parameters and CLI argument for displaying the real-world date and time #110

merged 4 commits into from
Aug 1, 2019

Conversation

jpgill86
Copy link
Owner

@jpgill86 jpgill86 commented Aug 1, 2019

No description provided.

jpgill86 added 4 commits August 1, 2019 12:58
@jpgill86
Add datetime parameters to EphyviewerConfigurator
5b1c332 
This feature is disabled by default because it is not always accurate if the data file includes pauses in the data acquisition.
@jpgill86
Add datetime option to standalone app
3f0d05e
@jpgill86
Add datetime CLI argument
00e4410
@jpgill86
Add install instructions for ephyviewer dev
2a7a9fc
@jpgill86 jpgill86 added the enhancement New feature or request label Aug 1, 2019
@jpgill86 jpgill86 added this to the 1.1.0 milestone Aug 1, 2019
@jpgill86 jpgill86 merged commit 2e65c76 into master Aug 1, 2019
@jpgill86 jpgill86 deleted the show-datetime branch August 1, 2019 17:51
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 44.181% when pulling 2a7a9fc on show-datetime into f933590 on master.

@jpgill86
Copy link
Owner Author

jpgill86 commented Aug 1, 2019

I just discovered that, for continuous acquisition mode at least, an AxoGraph file's rec_datetime (parsed from the file's "Notes") actually corresponds to the moment the chart was created (when "New Chart" was clicked), not when recording started (when "Run Chart" was clicked).

jpgill86 added a commit that referenced this pull request Oct 9, 2019
@jpgill86
Update requirements to use ephyviewer 1.2.0
3dcc2a1 
ephyviewer 1.2.0 or later is needed for ``ephyviewer.MainViewer(datetime_format = ...)``, which was introduced into neurotic in #110.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpgill86 @coveralls