fix: repositoryUrl listed as required but build fails when not included #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3745c22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for the PR @colmcgiv. I'll be taking a look soon at it 💜 |
…ails when not included
jpedroschmitz
approved these changes
Mar 26, 2021
|
Great news! Thanks @jpedroschmitz 🎉 |
|
I really appreciated your PR! 2.3.1 was released on NPM with the fix! |
|
Excellent! Thanks for the great theme |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed
Removing
repositoryUrlfrom the theme options causes the build to fail, this option is listed as not being required so the theme should handle this.This fix should allow
repositoryUrlto be omitted from the theme options if desired.Additional context