Refactor login sequence so that it no longer depends on unrelated server messages #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #809 +/- ##
==========================================
+ Coverage 99.39% 99.42% +0.03%
==========================================
Files 183 183
Lines 6250 6257 +7
Branches 945 947 +2
==========================================
+ Hits 6212 6221 +9
+ Misses 21 20 -1
+ Partials 17 16 -1 ☔ View full report in Codecov by Sentry. |
jpdillingham
force-pushed
the
server-info-refactor
branch
from
06b2176 to
e1d4c67
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#805 improved logging in this area but after thinking about it for a while I no longer think it's a good idea to even couple these things to the login; the data isn't necessary for the client to function.
This PR moves the handling of
ParentMinSpeed,ParentSpeedRatioandWishlistIntervalout of band.The
ServerInfoReceivedevent will fire each time any of the four captured properties is received; the first time at successful login, settingIsSupporter, and then once for each of the other three. The associated properties will remainnulluntil the data is received, and if the server doesn't send it, no big deal.The observed defaults for these properties are:
ParentMinSpeed: 1ParentSpeedRatio: 50WishlistInterval: 720 (seconds, or 12 minutes)This PR also corrects a mistake in the documentation;
WishlistIntervalis expressed in seconds, not milliseconds. Anyone relying on this value to perform wishlist searches should make an adjustment immediately.