Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the responseReceived parameter of SearchAsync to responseHandler #770

Merged
merged 1 commit into from
Nov 27, 2022

Conversation

jpdillingham
Copy link
Owner

Closes #738

@jpdillingham jpdillingham added the breaking change This is a breaking change label Nov 27, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #770 (a5c6760) into master (3c92e90) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #770   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files         179      179           
  Lines        6176     6176           
  Branches      934      934           
=======================================
  Hits         6128     6128           
  Misses         31       31           
  Partials       17       17           
Impacted Files Coverage Δ
src/BrowseResponse.cs 52.38% <ø> (ø)
src/SoulseekClient.cs 99.31% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jpdillingham jpdillingham merged commit 72061b6 into master Nov 27, 2022
@jpdillingham jpdillingham deleted the callback branch November 27, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This is a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

responseReceived in SearchOptions and in the signature of SearchAsync() are confusing
1 participant