Fix553 name inconsistency #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lete; otherwise bailing out will end up with a closed database.
|
@joyfullservice this is ready; merge after the other two. |
|
@hecon5 FYI - this needs to be updated; there's conflicts. |
|
I'll get these conflicts fixed shortly, looks like the translate updates were parallel. |
|
Sounds good. I will keep my eyes out for the update... |
…nsistency # Conflicts: # Version Control.accda.src/forms/frmVCSMain.cls # Version Control.accda.src/modules/modImportExport.bas
… remove use of vbCrLf and convert to vbNewLine.
|
Thanks @joyfullservice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fixes #553 and improves error handling and bailout of a failed build.
Merge this AFTER #557 (it relies on several fixes required in that PR).
If a name discrepancy is discovered, a user will be presented with an error:
The addin will then throw a critical error and bail out as shown:
The addin will then display build failed:
