unix,win: add uv_fs_access()

[cjihrig]

@saghul here is the uv_fs_access() PR you asked for. The Unix side seems to be working, but on the Windows side, GetFileAttributesW() is always returning INVALID_FILE_ATTRIBUTES. Suggestions are more than welcome.

[saghul]

Thanks Colin! I'll check it asap (I'm moving these days and my Windows gear is in a box somewhere...)

[trevnorris]

style nit: prefer the following:

int uv_fs_access(uv_loop_t* loop,
                 uv_fs_t* req,
                 const char* path,
                 int flags,
                 uv_fs_cb cb) {

[cjihrig]

I agree, but this seems to be the convention used throughout this file.

[trevnorris]

@saghul keep convention w/ the rest of the file, or use the usual indentation?

[saghul]

I'd go with the usual.

[cjihrig]

@saghul addressed the previous round of comments and got it working on Windows.

[saghul]

No need for braces.

[saghul]

Good work Chris! Looks solid. I'll merge once after running it for a spin on Windows. Did you look into what @piscisaureus said about GetFileAttributesW? At any rate, it can be improved at a later stage since it's an implementation detail.

[cjihrig]

@saghul removed the braces. I didn't look into opening and closing the file, as their seemed to be a potential issue if the file was locked by another process. Linking to the node PR for future reference.

[saghul]

Cheers, Colin! Landed in c18205a.

[cjihrig]

Awesome. Thanks for the help @saghul. @trevnorris I'm sure you'll get an email about this, but you asked me to let you know when this landed.