Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting of environment #123

Closed
laurenceputra opened this issue Mar 7, 2017 · 6 comments
Closed

Setting of environment #123

laurenceputra opened this issue Mar 7, 2017 · 6 comments

Comments

@laurenceputra
Copy link
Contributor

Currently I'm not able to set the environment of the app without making modifications to the library. Possible to expose a function to do that?
@marcomorain
Copy link
Collaborator

Hi @laurenceputra that sounds like a good addition to the library. We'd happily accept a PR if you have the time.

I would do it by putting a public method on the SentryEventBuilder class setEnvironment(String env).

laurenceputra added a commit to laurenceputra/Sentry-Android that referenced this issue Mar 9, 2017
@laurenceputra
Added API to set environment in SentryEventBuilder.
7a5ebc4 
Fixes joshdholtz#123
@laurenceputra laurenceputra mentioned this issue Mar 9, 2017
Closed
laurenceputra added a commit to laurenceputra/Sentry-Android that referenced this issue Mar 9, 2017
@laurenceputra
Added API to set environment in SentryEventBuilder.
1439c21 
Fixes joshdholtz#123
@laurenceputra laurenceputra mentioned this issue Mar 9, 2017
Merged
@MihaelIsaev
Copy link

Could someone please build a new version and upload it to jCenter?
I want to use environment feature 7a5ebc4

@seljabali
Copy link

@joshdholtz?

@joshdholtz
Copy link
Owner

joshdholtz commented May 25, 2017 •
edited
Loading

@MihaelIsaev @seljabali Popped out a new build for you (v1.6.2). Sorry about taking so long!

@seljabali
Copy link

Thank you @joshdholtz

@joshdholtz
Copy link
Owner

Not a problem ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@joshdholtz @marcomorain @laurenceputra @seljabali @MihaelIsaev