-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UncaughtExceptionHandler doesn't add breadcrumbs to SentryEventBuilder #114
Comments
Hi Andrew, I'll gladly accept a patch for this. Marc |
Hi Marc, Thanks for your quick response. Depending on my work schedules over the next few weeks I'll have a go at adding this. I'm somewhat of a GitHub newbie: I assume I fork your repo, and then submit a Pull Request back to you with my changes? Many thanks, Andrew. |
Hi Andrew, I've committed a fix for this this evening - @joshdholtz want to kick off another release? 🚀 |
When Sentry-Android handles a runtime exception with its uncaughtExceptionHandler it doesn't appear to add any accumulated breadcrumbs to the event posted to the Sentry server, whereas manually caught exceptions posted with Sentry.captureException and Sentry.captureEvent do include breadcrumbs.
Is there a reason why the uncaughtExceptionHandler omits breadcrumbs? It would be quite useful for determining the events leading up to a runtime crash.
Would it be possible to add this for uncaught exceptions in a future release?
I'm currently using Sentry-Android 1.5.2 in my app as this appears to be the latest I can get from jCenter.
The text was updated successfully, but these errors were encountered: