Rename data table #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@shinytoyrobots @alisonjoseph Do you think it's worth the risk? Another risk is doing the rename in |
|
@asudoh i think this rename will lead to more consistent usage and adoption, and will make for an easier transition for project teams when migrating from |
|
@lovemecomputer You are right that we are talking about the short timespan. @vpicone Do you want to rebase BTW? |
joshblack
pushed a commit
that referenced
this pull request
May 2, 2019
carbon-design-system#1702) * fix: Removed the role of button from the expandable tile, resolves carbon-design-system#1583. * fix: removed the tab index from the div of the expandable tile, resolves 1702.
joshblack
added a commit
that referenced
this pull request
Jun 17, 2019
* chore(project): update LICENSE * chore(project): setup project files * chore(project): add github files
joshblack
added a commit
that referenced
this pull request
Jun 17, 2019
* chore(project): update LICENSE * chore(project): setup project files * chore(project): add github files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directed towards upstream PR: carbon-design-system#2208
Renames all instances of data-table-v2 to data-table