Skip to content

Commit

Permalink
fix(type): update $productive-heading-05 weights to Light (300) (carb…
Browse files Browse the repository at this point in the history
…on-design-system#219)

* Update $productive-heading-05 to Light weight 

$expressive-heading-04 and -05 are using the light weight at 28px; $productive-heading-05 needs to be updated to match.

* chore(type): sync to styles and snapshots
  • Loading branch information
jeanservaas authored and joshblack committed Jan 3, 2019
1 parent 627599a commit 6eb3b0a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
5 changes: 4 additions & 1 deletion packages/type/scss/_styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ $productive-heading-04: (
$productive-heading-05: (
font-family: font-family('sans'),
font-size: type-scale(8),
font-weight: font-weight('regular'),
font-weight: font-weight('light'),
line-height: rem(40px),
letter-spacing: 0,
) !default;
Expand All @@ -133,14 +133,17 @@ $expressive-heading-04: (
),
lg: (
font-size: type-scale(7),
font-weight: font-weight('light'),
line-height: 125%,
),
xlg: (
font-size: type-scale(7),
font-weight: font-weight('light'),
line-height: 129%,
),
max: (
font-size: type-scale(8),
font-weight: font-weight('light'),
line-height: 125%,
),
),
Expand Down
4 changes: 2 additions & 2 deletions packages/type/src/__tests__/__snapshots__/styles-test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ exports[`styles productiveHeading05 should be printable 1`] = `
Object {
"fontFamily": "'IBM Plex Sans', 'Helvetica Neue', Arial, sans-serif",
"fontSize": "2rem",
"fontWeight": 400,
"fontWeight": 300,
"letterSpacing": 0,
"lineHeight": "2.5rem",
}
Expand All @@ -500,7 +500,7 @@ Object {
exports[`styles productiveHeading05 should be printable 2`] = `
"font-family: 'IBM Plex Sans', 'Helvetica Neue', Arial, sans-serif;
font-size: 2rem;
font-weight: 400;
font-weight: 300;
line-height: 2.5rem;
letter-spacing: 0;"
`;
Expand Down
2 changes: 1 addition & 1 deletion packages/type/src/styles.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export const productiveHeading04 = {
export const productiveHeading05 = {
fontFamily: fontFamilies.sans,
fontSize: rem(scale[7]),
fontWeight: fontWeights.regular,
fontWeight: fontWeights.light,
lineHeight: rem(40),
letterSpacing: 0,
};
Expand Down

0 comments on commit 6eb3b0a

Please sign in to comment.