Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social sharing buttons #25

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

leason
Copy link

@leason leason commented Mar 30, 2019

Three new optional params added to the site config:

  • twitterHandle = "your-twitter-handle"
  • shareOnLinkedIn = true/false
  • shareOnTwitter = true/false

If you supply twitterHandle a "follow me on twitter" button is added to the footer and displayed on all pages.

The shareOnLinkedIn and shareOnTwitter options allow you to show or hide the respective share icons that are displayed on post pages rendered through single.html.

I pulled in the latest style.css and re-created the main.min.css file. I believe it includes the latest changes.

@leason
Copy link
Author

leason commented Mar 30, 2019

This will resolve #22

@leason
Copy link
Author

leason commented Mar 30, 2019

Also, you can see this live on https://eason.blog

@leason
Copy link
Author

leason commented Mar 31, 2019

@josephhutch is the minified CSS here okay with you or do you want me to run it through the same minifier you've been using and resubmit? Happy to do that if you'd prefer it that way.

@leason
Copy link
Author

leason commented Mar 31, 2019

I saw your minify CSS command and just pushed an update to the main.min.css file. It includes the xcode and font css now. Give it a look and let me know what you think.

@leason
Copy link
Author

leason commented Apr 12, 2019

@josephhutch did you need anything else from me on this?

@josephhutch
Copy link
Owner

@leason Thank you for the updates! I am going to work on introducing your changes in a way that better fits the visual style of the theme. Your blog is looking great by the way, let me know if there is anything else I can do to improve this theme.

@Barsonax
Copy link

Barsonax commented Aug 14, 2019

On my fork I added some social media buttons to aether, maybe these fit the style a bit better:
image
https://www.the-photographing-programmer.com/
https://github.com/Barsonax/aether/tree/d86ca84bdf9418a19761c649bc420540b41a7729

Note: actual icons were taken from Jekyll Now which I used previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants