Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type definition missing for matrixFrom* #3115

Closed
Hime-Hina opened this issue Dec 22, 2023 · 4 comments · Fixed by #3371
Closed

Type definition missing for matrixFrom* #3115

Hime-Hina opened this issue Dec 22, 2023 · 4 comments · Fixed by #3371
Labels
bug help wanted typescript

Comments

@Hime-Hina
Copy link

The issues section is used only for bug reports. Please use the Discussions section to ask questions and share ideas and suggestions.

Describe the bug
The type definition of matrixFromRows is missing, also for matrixFromColumns and matrixFromFunction.

图片

To Reproduce

Create a simple typescript project.

pnpm init
pnpm add typescript -D
pnpm add mathjs
.\node_modules\.bin\tsc --init
@josdejong
Copy link
Owner

Thanks for reporting.

Anyone able to add those functions to the type definitions? Help would be welcome!

@Hudsxn
Copy link
Contributor

Hudsxn commented Jan 31, 2024

Hi Again @josdejong, I can fill this in if you'd like?

@josdejong
Copy link
Owner

Yes please! Thanks!

Hudsxn added a commit to Hudsxn/mathjs that referenced this issue Feb 1, 2024
@Hudsxn
Type definition missing for matrixFrom* josdejong#3115
7f0a8a2
@Hudsxn
Copy link
Contributor

Hudsxn commented Feb 1, 2024

Hi @josdejong
Made the changes, and a couple of small improvements. :)
#3146

@gwhitney gwhitney mentioned this issue Jan 29, 2025
Merged
josdejong pushed a commit that referenced this issue Jan 29, 2025
@gwhitney @Hudsxn
fix: type definitions for matrixFrom* (#3371)
b56fbcb 
* Addressed silentmissile's comment in #3125

* Added method overload to index.d.ts, have to revert commit due to changes to package-lock.json with using npm install to run the unit tests & lint tests

* Type definition missing for matrixFrom* #3115

* fix: Update types and add tests as requested by review

* chore: lint fix

---------

Co-authored-by: Hudsxn <[email protected]>
Co-authored-by: Hudsxn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Type definitions for matrixFrom* gwhitney/mathjs
3 participants
@josdejong @Hime-Hina @Hudsxn